[
https://issues.apache.org/jira/browse/CASSANDRA-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081521#comment-18081521
]
Matt Byrd commented on CASSANDRA-21341:
---------------------------------------
PRS for this are here:
https://github.com/apache/cassandra/pull/4817
https://github.com/apache/cassandra/pull/4818
One slight wrinkle was that the test which would have actually caught this
omission was modified during the TCM merge to make it not possible to fail.
We changed the decommission target to no longer be a CMS node, understandably
to avoid a test failure, but in doing so made the test vacuously pass, hence
the additional changes within associated test.
Am running CI and will try and attach them both tomorrow.
FYI
[~smiklosovic][~samt]
> transfer_hints_on_decommission seems to be dead property in post-TCM
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-21341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21341
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Transactional Cluster Metadata
> Reporter: Stefan Miklosovic
> Assignee: Matt Byrd
> Priority: Normal
>
> StorageService.unbootstrap in Cassandra < 6.0 has this in it
> {code}
> if (DatabaseDescriptor.getTransferHintsOnDecommission())
> {
> setMode(Mode.LEAVING, "streaming hints to other nodes", true);
> hintsSuccess = streamHints();
> }
> {code}
> in TCM this was rewritten into {{UnbootstrapStreams.unbootstrap}} but
> streaming of hints is not wrapped in that {{if}}, making
> {{DatabaseDescriptor.getTransferHintsOnDecommission()}} unused property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
