[ 
https://issues.apache.org/jira/browse/CASSANDRA-21341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082447#comment-18082447
 ] 

Matt Byrd commented on CASSANDRA-21341:
---------------------------------------

hehe thanks, ironically I had also initially removed the prefix, but added it 
back in in-case someone is grepping or has logging automation/alerting on those 
exact strings with mode prefix.
I agree it reads a bit cleaner without and likelihood anyone has automation on 
that exact log message is probably low.

> transfer_hints_on_decommission seems to be dead property in post-TCM 
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-21341
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21341
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Consistency/Hints
>            Reporter: Stefan Miklosovic
>            Assignee: Matt Byrd
>            Priority: Normal
>             Fix For: 6.0-alpha2
>
>         Attachments: ci_summary_CASSANDRA-21341_cassandra-6.0.html, 
> ci_summary_CASSANDRA-21341_trunk.html
>
>
> StorageService.unbootstrap  in Cassandra < 6.0 has this in it
> {code}
> if (DatabaseDescriptor.getTransferHintsOnDecommission())
>         {
>             setMode(Mode.LEAVING, "streaming hints to other nodes", true);
>             hintsSuccess = streamHints();
>         }
> {code}
> in TCM this was rewritten into {{UnbootstrapStreams.unbootstrap}} but 
> streaming of hints is not wrapped in that {{if}}, making 
> {{DatabaseDescriptor.getTransferHintsOnDecommission()}} unused property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to