[ 
https://issues.apache.org/jira/browse/CASSANDRA-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166350#comment-13166350
 ] 

Eric Evans commented on CASSANDRA-2475:
---------------------------------------

{quote}
While I agree in principle, from CASSANDRA-1788, CASSANDRA-3333, and others, 
we've seen that reducing copies really matters to CPU-bound queries. So I would 
expect the same here; convert-from-string is basically a glorified copy.
{quote}

Is it more expensive to parse them as strings?  Sure, but evaluating the 
cost-to-benefit could be difficult enough _without_ guessing at what that cost 
is. :)  Whether it's preserialized binary, or string, it should be one or the 
other and it sounds like no one is in disagreement there.  Testing it both ways 
should be very easy, so I suggest we revisit this part of the discussion (if 
necessary) after we have some real data.

bq. We're already doing binary data for resultsets, so I don't think the bar 
for client developers gets much higher if we use them for prepared statements.

If by bar you mean skills/capabilities, then sure, but that wasn't my concern.

Serializing _to_ bytes is a Whole Other Thing, it's not as if already doing the 
one, is going to make doing the other any easier/less error-prone.  It's also 
two very different vectors for bugs, multiplied by the number of client 
implementations.  And, it is very different than deserializing results which 
can only happen one way, a serialization bug could mean that 
{{execute_cql_query()}} and {{execute_prepared_cql_query()}} do very different 
things with the same query.
                
> Prepared statements
> -------------------
>
>                 Key: CASSANDRA-2475
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2475
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>    Affects Versions: 1.0.5
>            Reporter: Eric Evans
>            Assignee: Rick Shaw
>            Priority: Minor
>              Labels: cql
>             Fix For: 1.1
>
>         Attachments: 2475-v1.patch, 2475-v2.patch, 
> v1-0001-CASSANDRA-2475-prepared-statement-patch.txt, 
> v1-0002-regenerated-thrift-java.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to