sarankk commented on code in PR #238:
URL: 
https://github.com/apache/cassandra-analytics/pull/238#discussion_r4018411791


##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/CqlUtilsTest.java:
##########
@@ -142,6 +142,84 @@ public void testExtractReplicationFactor(CassandraBridge 
bridge)
         assertThat(systemSchemaRf.getOptions()).isEqualTo(ImmutableMap.of());
     }
 
+    @Test
+    public void testExtractReplicationFactorWithWitnessReplicas()
+    {
+        // Witness-enabled keyspace as created by Cassandra's 
WitnessAlwaysReadsFullReplicaTest on the
+        // cep-45-mutation-tracking branch: the <replicas>/<transient> form 
plus replication_type = 'tracked'
+        String schema = "CREATE KEYSPACE witnessks WITH REPLICATION = 
{'class': 'NetworkTopologyStrategy', "
+                        + "'datacenter1': '3/1', 'datacenter2': '3/1'} AND 
replication_type = 'tracked' "

Review Comment:
   `replication_type = 'tracked'` this field is not yet supported in Sidecar 
schema response, shall we remove this from example? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to