mansikhara commented on code in PR #238:
URL:
https://github.com/apache/cassandra-analytics/pull/238#discussion_r4020075785
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/ReplicationFactor.java:
##########
@@ -108,11 +114,44 @@ public static ReplicationFactor simpleStrategy(int rf)
private final ReplicationStrategy replicationStrategy;
@NotNull
private final Map<String, Integer> options;
+ /**
+ * Per-datacenter count of transient (witness) replicas, parsed from the
{@code <replicas>/<transient>} form.
+ * A datacenter absent from this map has no transient replicas. Always
empty for untracked keyspaces using the
+ * plain {@code <replicas>} form, which keeps behaviour identical for
those keyspaces.
+ */
+ @NotNull
+ private final Map<String, Integer> transientOptions;
+ /**
+ * Lenient parse: a replication value that cannot be parsed is logged and
its datacenter omitted. Retained for
Review Comment:
None, as it turns out. I checked the callers and there are only two,
ReplicationFactorSupplier and CdcOptions, and both build hardcoded maps that
cannot fail to parse. So I have removed the lenient path entirely and made
strict the only behaviour! Thanks for the find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
