[
https://issues.apache.org/jira/browse/CASSPYTHON-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125693#comment-18125693
]
Jeremiah Jordan commented on CASSPYTHON-29:
-------------------------------------------
> a canonical key is valuable in a way that free-form keys aren't
I agree with this. APPLICATION_NAME and APPLICATION_VERSION are pretty generic
names, and also apply to just about everything. I don't think we should remove
the existing "canonical" keys from any of the drivers.
But I would also be for adding the ability to them for someone to add what ever
freeform keys they want besides those. Ease of adding freeform keys means
people can experiment with adding new ones for things and it also means that if
a new free form key becomes "canonical" in the future, older version users can
start to send it if they want, without having to upgrade to a new driver
release that supports it.
But I would recommend rejecting any "canonical" key that shows up in the
freeform keys list. Also I don't see how some string in the STARTUP message
become an attack vector. Anyway all the drivers are open source, so if someone
wanted to use STARTUP as an attack vector they already can, just edit the
driver source to add their new key/value pair.
> Allow user to specify arbitrary parameters for STARTUP message
> --------------------------------------------------------------
>
> Key: CASSPYTHON-29
> URL: https://issues.apache.org/jira/browse/CASSPYTHON-29
> Project: Apache Cassandra Python driver
> Issue Type: Improvement
> Components: Core
> Reporter: Swathi Sekar
> Assignee: Bohdan Siryk
> Priority: Normal
> Fix For: 4.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Modify the driver to allow sending arbitrary STARTUP message options.
> Proposed design:
> - Add `extra_startup_options` param to Cluster constructor.
> - Thread it through Cluster -> connection setup (cluster.py) ->
> StartupMessage.
> - Define clear precedence/conflict behavior when duplicate/conflicting
> options are passed into the StartupMessage constructor.
> *Note:*
> This Jira was originally created for sending the client's application name
> and version as `APPLICATION_NAME` /
> `APPLICATION_VERSION` options in the STARTUP message, which is tied to the
> now-defunct DataStax Insights offering.
> Since the Java driver (5.0.0) and eventually C/C++ driver (3.0.0) are
> removing withApplicationName()/withApplicationVersion() entirely, this ticket
> has been updated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
