[
https://issues.apache.org/jira/browse/CASSANDRA-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173224#comment-13173224
]
Jonathan Ellis commented on CASSANDRA-3649:
-------------------------------------------
bq. no patch from before the refactor will ever apply
This is why we haven't done it in the past, but we don't have an outstanding
backlog of large patches now. Additionally, if someone has a private set of
Truly Epic patches, or if we want to resurrect an older one like CASSANDRA-678,
we can always do it by reformatting the code the patch was generated against
pre- and post- patch to get a modern-formatted patch. *I note, for vim users,
that this is less than two minutes worth with a modern IDE. :)
Not something I'd want to do every day, but like I said, we don't have a patch
backlog large enough that this scares me.
bq. including everything that will be committed to some older version and
merged up
As Brandon mentioned, I think we should reformat the 1.0 branch (just the
brace-on-newline part) to make this no more of an issue than if we were
sticking to just underscore removal etc. I think 0.7 and 0.8 are inactive
enough that we don't merge from them anymore, but we could include them in the
reformat too if you like. 0.8 could make sense, but we'll see where we are in
a month after 0.8.10.
> Code style changes, aka The Big Reformat
> ----------------------------------------
>
> Key: CASSANDRA-3649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3649
> Project: Cassandra
> Issue Type: Wish
> Components: Core
> Reporter: Brandon Williams
> Fix For: 1.2
>
>
> With a new major release coming soon and not having a ton of huge pending
> patches that have prevented us from doing this in the past, post-freeze looks
> like a good time to finally do this. Mostly this will include the removal of
> underscores in private variables, and no more brace-on-newline policy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
