[ 
https://issues.apache.org/jira/browse/CASSANDRA-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207132#comment-13207132
 ] 

Yuki Morishita commented on CASSANDRA-3772:
-------------------------------------------

Dave,

Patch needs rebase, but looking at the patch, I noticed the following:

{code}
private static byte[] hashMurmur3(ByteBuffer... data)
{
    HashFunction hashFunction = murmur3HF.get();
    Hasher hasher = hashFunction.newHasher();
    // snip
}
{code}

Isn't that slow if you instantiate every time? I looked up guava source code 
but I saw no way to "reset", so I guess the above is the only thing you could 
do...

I also note that CASSANDRA-2975 will implement MurmurHash3, so I think it is 
better not to introduce external library. What do you think?
                
> Evaluate Murmur3-based partitioner
> ----------------------------------
>
>                 Key: CASSANDRA-3772
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3772
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Dave Brosius
>             Fix For: 1.2
>
>         Attachments: try_murmur3.diff
>
>
> MD5 is a relatively heavyweight hash to use when we don't need cryptographic 
> qualities, just a good output distribution.  Let's see how much overhead we 
> can save by using Murmur3 instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to