[ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255143#comment-13255143 ]
Pavel Yaskevich edited comment on CASSANDRA-4138 at 4/16/12 10:55 PM: ---------------------------------------------------------------------- To avoid confusion related to naming of {write, read}VLong methods (as it gives a feeling that writeInt doesn't really write an int anymore) in the EDIS and EDOS I propose to rename them to VInt{Encode, Decode}. Furthermore, we could give a better feel of the encoding used by adding {VInt} as a prefix to both classes (as an alternative they could be moved to o.a.c.u.vint package), also I think the DBContants class is now should be changed to only share sizeof(type) methods and become something like DBContants.{native, vint}.sizeof(type)... was (Author: xedin): To avoid confusion related to naming of {write, read}VLong methods (as it gives a feeling that writeInt doesn't really write an int anymore) in the EDIS and EDOS I propose to rename them to {encode, decode}VInt. Furthermore, we could give a better feel of the encoding used by adding {VInt} as a prefix to both classes (as an alternative they could be moved to o.a.c.u.vint package), also I think the DBContants class is now should be changed to only share sizeof(type) methods and become something like DBContants.{native, encoded}.sizeof(type)... > Add varint encoding to Serializing Cache > ---------------------------------------- > > Key: CASSANDRA-4138 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4138 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Affects Versions: 1.2 > Reporter: Vijay > Assignee: Vijay > Priority: Minor > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4138-Take1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira