[ 
https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255193#comment-13255193
 ] 

Vijay edited comment on CASSANDRA-4138 at 4/16/12 11:58 PM:
------------------------------------------------------------

Hi Pavel, attached patch has recommended changes except 

>>> I think the DBContants class is now should be changed to only share 
>>> sizeof(type) methods and become something like DBContants.{native, 
>>> vint}.sizeof(type)

I will mark it private once parent ticket is complete (Messaging and SSTable 
formats), currently we have it called in other places too.
                
      was (Author: vijay2...@yahoo.com):
    Hi Pavel, attached patch has recommended changes except 

{quote}
I think the DBContants class is now should be changed to only share 
sizeof(type) methods and become something like DBContants.{native, 
vint}.sizeof(type)
{quote}

I will mark it private once parent ticket is complete (Messaging and SSTable 
formats), currently we have it called in other places too.
                  
> Add varint encoding to Serializing Cache
> ----------------------------------------
>
>                 Key: CASSANDRA-4138
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4138
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 0001-CASSANDRA-4138-Take1.patch, 
> 0001-CASSANDRA-4138-V2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to