[ 
https://issues.apache.org/jira/browse/CASSANDRA-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402035#comment-13402035
 ] 

Jonathan Ellis commented on CASSANDRA-3047:
-------------------------------------------

Thanks, David.

I don't think effectiveOwnership needs to do quite so much work -- the Range 
map from Node is available from SS.getRangesForEndpoint, and of course 
token<->address map is in TokenMetadata.  (So I think we can dispense with Node 
entirely.)  dcsToEndpoints is not available in current trunk but CASSANDRA-3881 
adds it to the Topology class; should probably rebase this on top of that.

IMO we should probably change effectiveOwnership to map by address instead of 
token -- the former will make more sense when we add vnodes.
                
> implementations of IPartitioner.describeOwnership() are not DC aware
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-3047
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3047
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Aaron Morton
>            Assignee: David Alves
>            Priority: Trivial
>             Fix For: 1.1.2
>
>         Attachments: CASSANDRA-3047.patch, CASSANDRA-3047.patch, 
> CASSANDRA-3047.patch, CASSANDRA-3047.patch
>
>
> see http://www.mail-archive.com/user@cassandra.apache.org/msg16375.html
> When a cluster the multiple rings approach to tokens the output from nodetool 
> ring is incorrect.
> When it uses the interleaved token approach (e.g. dc1, dc2, dc1, dc2) it will 
> be correct. 
> It's a bit hacky but could we special case (RP) tokens that are off by 1 and 
> calculate the ownership per dc ? I guess another approach would be to add 
> some parameters so the partitioner can be told about the token assignment 
> strategy.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to