[ https://issues.apache.org/jira/browse/CASSANDRA-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402644#comment-13402644 ]
David Alves commented on CASSANDRA-3047: ---------------------------------------- thanks for the review and for the clues. code is much more succinct with topology and getRangesForEndpoint. final question, since we're changing the mapping to a per endpoint basis should we keep showing the tokens, or do something that would work straight out with vnodes such as (per dc): {code} Address DC Rack Status State Load Owns Num. Ranges RangeIds 127.0.0.4 DC3 RAC1 Up Normal 52.76 KB 75.00% 1 0 127.0.0.5 DC3 RAC1 Up Normal 54.46 KB 75.00% 1 1 127.0.0.6 DC3 RAC2 Up Normal 52.78 KB 75.00% 1 2 127.0.0.7 DC3 RAC2 Up Normal 52.78 KB 75.00% 1 3 {code} where range id is the position in the token ring starting from 0 and then allow to get the token delimiters for a range with another command (or get all for an endpoint?). > implementations of IPartitioner.describeOwnership() are not DC aware > -------------------------------------------------------------------- > > Key: CASSANDRA-3047 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3047 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Aaron Morton > Assignee: David Alves > Priority: Trivial > Fix For: 1.1.2 > > Attachments: CASSANDRA-3047.patch, CASSANDRA-3047.patch, > CASSANDRA-3047.patch, CASSANDRA-3047.patch > > > see http://www.mail-archive.com/user@cassandra.apache.org/msg16375.html > When a cluster the multiple rings approach to tokens the output from nodetool > ring is incorrect. > When it uses the interleaved token approach (e.g. dc1, dc2, dc1, dc2) it will > be correct. > It's a bit hacky but could we special case (RP) tokens that are off by 1 and > calculate the ownership per dc ? I guess another approach would be to add > some parameters so the partitioner can be told about the token assignment > strategy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira