[ 
https://issues.apache.org/jira/browse/CASSANDRA-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636656#comment-13636656
 ] 

Jonathan Ellis commented on CASSANDRA-5385:
-------------------------------------------

I'm confused by this whole ticket.  Which of these is incorrect?

# skipBloomFilters is only called on data in the Data componenet
# skipBloomFilters is only called against a 1.1 sstable
# 1.1 sstables only use Murmur2 Bloom filters

(Because if all of these are correct, then we shouldn't need the changes to 
IndexHelper introduced here.)
                
> IndexHelper.skipBloomFilters won't skip non-SHA filters
> -------------------------------------------------------
>
>                 Key: CASSANDRA-5385
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5385
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 2.0
>            Reporter: Carl Yeksigian
>            Assignee: Carl Yeksigian
>             Fix For: 1.2.4, 2.0
>
>         Attachments: 5385.patch, 5385-v2.patch
>
>
> Currently, if the bloom filter is not of SHA type, we do not properly skip 
> the bytes. We need to read out the number of bytes, as happens in the Murmur 
> deserializer, then skip that many bytes instead of just skipping the hash 
> size. The version needs to be passed into the method as well, so that it 
> knows what type of index it is, and does the appropriate skipping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to