[
https://issues.apache.org/jira/browse/CASSANDRA-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637617#comment-13637617
]
Carl Yeksigian commented on CASSANDRA-5385:
-------------------------------------------
{quote}
Hmm, looks like the backport blew away scrubtest on 1.2 as well. Oversight?
{quote}
Yes, was an oversight.
Just for clarification, skipBloomFilters is old.
#1 and #2 are incorrect.
1: The skipBloomFilters gets called on the index file in RowIndexEntry line 104.
2: In 2.0, the skipBloomFilters will be called on a 1.2 sstable; also, the
skipBloomFilters currently is called against any sstable when scrubbing.
> IndexHelper.skipBloomFilters won't skip non-SHA filters
> -------------------------------------------------------
>
> Key: CASSANDRA-5385
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5385
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.2.0, 2.0
> Reporter: Carl Yeksigian
> Assignee: Carl Yeksigian
> Fix For: 1.2.4, 2.0
>
> Attachments: 5385.patch, 5385-v2.patch
>
>
> Currently, if the bloom filter is not of SHA type, we do not properly skip
> the bytes. We need to read out the number of bytes, as happens in the Murmur
> deserializer, then skip that many bytes instead of just skipping the hash
> size. The version needs to be passed into the method as well, so that it
> knows what type of index it is, and does the appropriate skipping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
