Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485996375
##########
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##########
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
SelectTranslator {
private static final TranslationStage[] TRANSLATION_STAGES = {
new ColumnExtractorStage(),
new PrefetchNodeStage(),
- new OrderingStage(),
new QualifierTranslationStage(),
new HavingTranslationStage(),
- new GroupByStage(),
new DistinctStage(),
+ new OrderingStage(), // Relies on DistinctStage
Review Comment:
Another possible solution is to move the bulk of the logic in
`DistinctStage.perform` to `TranslatorContext`, then I can revert this change.
What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
