Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486306763
##########
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##########
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
SelectTranslator {
private static final TranslationStage[] TRANSLATION_STAGES = {
new ColumnExtractorStage(),
new PrefetchNodeStage(),
- new OrderingStage(),
new QualifierTranslationStage(),
new HavingTranslationStage(),
- new GroupByStage(),
new DistinctStage(),
+ new OrderingStage(), // Relies on DistinctStage
Review Comment:
I've restored the original Stage ordering in DefaultSelectTranslator and
instead moved all the shared logic code into a StageUtil class. This process
revealed that Orderings with compound paths now had to be explicitly dealt with
in OrderingStage :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
