my-ship-it commented on code in PR #1059:
URL: https://github.com/apache/cloudberry/pull/1059#discussion_r2055553118
##########
src/include/nodes/execnodes.h:
##########
@@ -374,15 +374,21 @@ typedef struct ProjectionInfo
* attribute numbers of the
"original" tuple and the
* attribute numbers of the
"clean" tuple.
* resultSlot: tuple slot used to hold cleaned tuple.
+ * execFilterJunk: function pointer to the function that will be
used
+ * to filter the junk attributes
from the input tuple.
* ----------------
*/
+typedef struct JunkFilter JunkFilter;
+typedef TupleTableSlot* (*ExecFilterJunkFunc)(JunkFilter *junkfilter,
+
TupleTableSlot *slot);
typedef struct JunkFilter
{
NodeTag type;
List *jf_targetList;
TupleDesc jf_cleanTupType;
AttrNumber *jf_cleanMap;
TupleTableSlot *jf_resultSlot;
+ ExecFilterJunkFunc jf_execFilterJunkFunc;
Review Comment:
It's better to test whether performance downgrade here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
