zhangyue-hashdata commented on code in PR #1059:
URL: https://github.com/apache/cloudberry/pull/1059#discussion_r2057224176
##########
src/include/nodes/execnodes.h:
##########
@@ -374,15 +374,21 @@ typedef struct ProjectionInfo
* attribute numbers of the
"original" tuple and the
* attribute numbers of the
"clean" tuple.
* resultSlot: tuple slot used to hold cleaned tuple.
+ * execFilterJunk: function pointer to the function that will be
used
+ * to filter the junk attributes
from the input tuple.
* ----------------
*/
+typedef struct JunkFilter JunkFilter;
+typedef TupleTableSlot* (*ExecFilterJunkFunc)(JunkFilter *junkfilter,
+
TupleTableSlot *slot);
typedef struct JunkFilter
{
NodeTag type;
List *jf_targetList;
TupleDesc jf_cleanTupType;
AttrNumber *jf_cleanMap;
TupleTableSlot *jf_resultSlot;
+ ExecFilterJunkFunc jf_execFilterJunkFunc;
Review Comment:
> It's better to test whether performance downgrade here?
The TPC-DS test shows no performance downgrade; details are provided below:
TPC-DS 1GB on a single node setup with x86_64 architecture, Intel Core i7,
and 16GB memory. The test was conducted three times, and the average value was
calculated as follows:
| | 1 | 2 | 3 | avg |
|---|---|---|---|---|
| before | 327s| 325s| 325s | 325.6s |
| after | 326s | 324s | 322s | 324s |
This table demonstrates the time in seconds for each test run and their
averages before and after the change, showing that there is no performance
downgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
