leborchuk commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2143582100


##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
 generate_greenplum_path_file:
        mkdir -p $(DESTDIR)$(prefix)
        unset LIBPATH; \
-       bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+       bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+       ln -s  $(DESTDIR)$(prefix)/cloudberry-env.sh 
$(DESTDIR)$(prefix)/greenplum_path.sh

Review Comment:
   Hm, I think the link should be created in the %post section of the rpm 
package. Because we copy the source file when installing the rpm package, and 
we cannot copy a symbolic link, we should create it again.
   
   https://stackoverflow.com/questions/7521980/packaging-symlinks-via-rpmbuild



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to