edespino commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2144287323
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh
$(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
This link should not be made. The entire code base (multiple repositories)
needs to be updated to handle the new name. This symbolic link hides those
changes.
This change is essentially removing all dependent references to
greenplum_path.sh. Everything needs to reference the new file cloudberry-env.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
