leborchuk commented on PR #1166: URL: https://github.com/apache/cloudberry/pull/1166#issuecomment-3070069267
> > Sorry for the noise here. The file generate-greenplum-path.sh has been changed, so I should rebase. I left generate-greenplume-path.sh as-is with the "NOTICE from the Apache Cloudberry PPMC". > > I think we will delete it when all the work is done. > > Since we're replacing all the old filenames in this PR, the NOTICE file becomes unnecessary. I recommend removing both the license headers and NOTICE references in this PR as well. @leborchuk FYI. Yep, removed the NOTICE and all occurrences of greenplum_path that were found in the code. Some of them were manually executed scripts, like src/backend/gporca/scripts/get_debug_event_counters.py, or inside beehave tests. I just changed them using a sed script and didn't check if they still worked or not. I launched build&configure&create/destroy&check_world, and everything worked fine. I believe that should be enough ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
