tuhaihe commented on code in PR #1166:
URL: https://github.com/apache/cloudberry/pull/1166#discussion_r2206466326
##########
gpMgmt/Makefile:
##########
@@ -6,12 +6,13 @@ SUBDIRS= sbin bin doc
$(recurse)
-generate_greenplum_path_file:
+generate_cloudberry_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ cp $(DESTDIR)$(prefix)/cloudberry-env.sh
$(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
We can remove this line. There is no need to create a `greenplum` file
again. We can provide an optional alias method in the documentation instead of
the source code, like:
```
sudo ln -s /usr/local/cloudberry-db/cloudberry-env.sh
/usr/local/cloudberry-db/greenplum_path.sh
```
##########
gpMgmt/Makefile:
##########
@@ -6,12 +6,13 @@ SUBDIRS= sbin bin doc
$(recurse)
-generate_greenplum_path_file:
+generate_cloudberry_path_file:
Review Comment:
We can also update the rule name to address the file name change:
```suggestion
generate_cloudberry_env_file:
```
##########
gpMgmt/test/behave/mgmt_utils/steps/mgmt_utils.py:
##########
@@ -2619,14 +2619,14 @@ def impl(context, location):
directory location for all hosts in the cluster.
"""
gphome = os.environ["GPHOME"]
- greenplum_path = path.join(gphome, 'greenplum_path.sh')
+ cloudberry_path = path.join(gphome, 'cloudberry-env.sh')
Review Comment:
That would be better to update this variable name too.
##########
gpMgmt/test/behave/mgmt_utils/steps/mgmt_utils.py:
##########
@@ -2619,14 +2619,14 @@ def impl(context, location):
directory location for all hosts in the cluster.
"""
gphome = os.environ["GPHOME"]
- greenplum_path = path.join(gphome, 'greenplum_path.sh')
+ cloudberry_path = path.join(gphome, 'cloudberry-env.sh')
Review Comment:
```suggestion
cloudberry-env = path.join(gphome, 'cloudberry-env.sh')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
