ostinru commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2645825338
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0
}}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [
"$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
Ok... It in fact more complicated than I thought before.
Old TestNG versions has bug https://github.com/testng-team/testng/issues/739
- when `@BeforeClass(alwaysRun = true)` fails - all tests are marked as SKIPPED
despite of `alwaysRun = true`. Fixed in 6.9.5+.
Originally, almost all tests in open-gpdb/pxf failed somwhere inside
`doInit()` methods - and all our tests were marked as SKIPPED. And then we
decided to think about such tests as FAILED.
So, it seems we can just bump testng version. In this scenario I will expect
that tests will be FAILED instead of SKIPPED. I will update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
