MisterRaindrop commented on code in PR #20:
URL: https://github.com/apache/cloudberry-pxf/pull/20#discussion_r2646646900
##########
.github/workflows/pxf-ci.yml:
##########
@@ -249,8 +253,11 @@ jobs:
- name: Check test result
if: always()
run: |
- if [ "${{ steps.run_test.outcome }}" == "failure" ]; then
- echo "Test group ${{ matrix.test_group }} failed"
+ FAILED_COUNT="${{ steps.collect_artifacts.outputs.failed_count || 0 }}"
+ SKIPPED_COUNT="${{ steps.collect_artifacts.outputs.skipped_count || 0
}}"
+
+ if [ "${{ steps.run_test.outcome }}" == "failure" ] || [
"$FAILED_COUNT" -gt 0 ] || [ "$SKIPPED_COUNT" -gt 0 ]; then
Review Comment:
It looks complicated. Please let me know when you're ready for the review. I
will review the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
