Mulily0513 commented on code in PR #22:
URL: https://github.com/apache/cloudberry-pxf/pull/22#discussion_r2647426774
##########
concourse/singlecluster/conf/gphd-conf.sh:
##########
@@ -4,14 +4,7 @@ if [ -z "${JAVA_HOME:-}" ]; then
if [ -n "${JAVA_HADOOP:-}" ]; then
export JAVA_HOME="${JAVA_HADOOP}"
else
- # Auto-detect Java 8 path for different architectures
- if [ -d "/usr/lib/jvm/java-8-openjdk-$(dpkg --print-architecture)" ]; then
- export JAVA_HOME="/usr/lib/jvm/java-8-openjdk-$(dpkg
--print-architecture)"
- elif [ -d "/usr/lib/jvm/java-8-openjdk" ]; then
- export JAVA_HOME="/usr/lib/jvm/java-8-openjdk"
- else
- export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
- fi
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk
Review Comment:
If the /usr/lib/jvm/java-8-openjdk/ directory indeed contains JDK versions
for multiple architectures, then the JDK should automatically select the
appropriate version based on the architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
