Mulily0513 commented on code in PR #22:
URL: https://github.com/apache/cloudberry-pxf/pull/22#discussion_r2647428936
##########
automation/src/main/java/org/greenplum/pxf/automation/utils/system/ProtocolUtils.java:
##########
@@ -23,15 +30,20 @@ public static ProtocolEnum getProtocol() {
}
public static String getSecret() {
- return System.getProperty(AWS_SECRET_ACCESS_KEY);
+ String secret = System.getProperty(AWS_SECRET_ACCESS_KEY);
+ return secret != null ? secret : System.getenv(AWS_SECRET_ACCESS_KEY);
}
public static String getAccess() {
- return System.getProperty(AWS_ACCESS_KEY_ID);
+ String access = System.getProperty(AWS_ACCESS_KEY_ID);
+ String result = access != null ? access :
System.getenv(AWS_ACCESS_KEY_ID);
+ System.out.println("DEBUG: doInit() method called getAccess " +
result);
Review Comment:
Yes, this is a debug print. It should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
