ostinru commented on issue #17:
URL: https://github.com/apache/cloudberry-pxf/issues/17#issuecomment-3776773355
I just figured out that `pxf_fdw` extension should be tested with separate
automation tests run (`make USE_FDW=true`)[1]. I have run it, and test results
are not as good[2] as other tests:
```
Tests run: 381, Failures: 49, Errors: 0, Skipped: 203
```
I thin that we can fix it. However, firstly we should decide on where we
keep `pxf_fdw` extension sources:
* in `cloudberry-pxf/fdw` - this version failed to compile against
cloudberry-pxf[4].
And we don't compile and install it when run `make install` due to [3].
* in `cloudberry/gpcontrib/pxf_fdw` - this version works well, however uses
deprecated (v15) API.
These versions diverged slightly, hovever it seems to be easy to backport
changes to either of them.
PS: I don't think that this should prevent us from merging
`merge-with-upstream` into `master` because we haven't decided which way pxf or
pxf_fdw we recommend to users[5].
[1]
https://github.com/apache/cloudberry-pxf/commit/240517464c896050875c4d112a77e719bc2735a1
[2] https://github.com/ostinru/cloudberry-pxf/pull/12
[3]
https://github.com/apache/cloudberry-pxf/blob/merge-with-upstream/Makefile#L10
[4] https://gist.github.com/ostinru/768e4fc07f5d36e15d403e262b00499a
[5] https://github.com/apache/cloudberry/issues/983#issuecomment-2796661810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
