my-ship-it commented on issue #17: URL: https://github.com/apache/cloudberry-pxf/issues/17#issuecomment-3788405507
> hi, when comparing cloudberry/pxf_fdw and cloudberry-pxf/fdw, I noticed some interesting points. They have similar functionalities but completely different code. > > **cloudberry/pxf_fdw** is implemented based on gp7, while cloudberry-pxf/fdw was initially based on gp6 and later extended to support gp7. > > **cloudberry/pxf_fdw** support only gp7(base on gp7) > > ``` > Implement PXF Foreign Data Wrapper > > PXF, (Platform Extension Framework) provides access to external data in > Greenplum[1]. Previously, it was based on external tables, this commit > introduces the FDW that can be used to communicate with PXF. > ... > commit： > c9d4c1e52ec06e1bca6263adcdc0eac414bb94cf [c9d4c1e52ec] > ``` > > cloudberry-pxf/fdw support gp7 and gp6 > > ``` > Changes for supporting PXF for GP7. > > Co-authored-by: Soumyadeep Chakraborty <[email protected]> > commit： > 48da41f24d58b43aec7451a3fd99c96dd18d70f7 > ``` > > ``` > [Add PXF FDW code to the PXF repository (#314)](https://github.com/apache/cloudberry-pxf/commit/069a09387eaeb7dd1763f3e3de205726b6d1d044) > * Add PXF FDW code to the PXF repository > > The PXF FDW code is moving to the PXF repository. The code is based on > the pxf_fdw_feature_6x version. > > * Address PR feedback > > * Disable BeginCopy until it is merged into 6X_STABLE > > * Validate that greenplum binaries are in the PATH > ``` > > 1. cloudberry-pxf/fdw is relatively older in implementation. > Since we don’t need to support gp6, it could be deprecated. > Therefore, I might pick some useful commits to apply to cloudberry/pxf_fdw. > 2. Another issue is whether upgrading cloudberry/pxf_fdw will impact cloudberry ? > Especially for current users. After all, we just made significant changes to the main branch of cloudberry-pxf, and its stability is still uncertain. > > [@tuhaihe](https://github.com/tuhaihe) [@ostinru](https://github.com/ostinru) [@my-ship-it](https://github.com/my-ship-it) Thank you for driving and raising the question. I think we need to use the fdw framework plus Foreign Table to implement this, so that kernel parallel execution can be more easily supported. Any other ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
