leborchuk commented on code in PR #47:
URL: https://github.com/apache/cloudberry-pxf/pull/47#discussion_r2762859552
##########
cli/cmd/cluster.go:
##########
@@ -111,9 +111,6 @@ func GenerateOutput(cmd *command, clusterData *ClusterData)
error {
}
response := ""
for _, failedCommand := range clusterData.Output.FailedCommands {
- if failedCommand == nil {
- continue
- }
Review Comment:
I see that we do not use nil as failed_command in tests anymore, but why
failedCommand cannot be nil anymore? I'd still check for nil, else we would
have nil dereference here. We could log on Error level all such situations. And
even panic here, but not fail with nil dereference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
