leborchuk commented on code in PR #47:
URL: https://github.com/apache/cloudberry-pxf/pull/47#discussion_r2762947085
##########
cli/cmd/cluster.go:
##########
@@ -111,9 +111,6 @@ func GenerateOutput(cmd *command, clusterData *ClusterData)
error {
}
response := ""
for _, failedCommand := range clusterData.Output.FailedCommands {
- if failedCommand == nil {
- continue
- }
Review Comment:
Yep, I see there is now a slice of structs, and check for errors, so no nil
items here anymore, thank you. It's safe to remove nil checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
