leborchuk commented on code in PR #1650: URL: https://github.com/apache/cloudberry/pull/1650#discussion_r3014622863
########## configure: ########## @@ -12235,7 +12236,9 @@ $as_echo "#define USE_MDBLOCALES 1" >>confdefs.h esac else - with_mdblocales=no + with_mdblocales=yes Review Comment: Does it enable mdb_locales by default? If yes, it's bad. It's needed an additional package with custom locales (individual for every installation). For example, one installation could have a frozen libc since Rocky Linux 8 and not change the symbol orders anymore. The second could have a frozen libc in Rocky Linux 9, and so on. I prefer not to enable it. Let's do not give custom locales for users by default, it's only for those who fully understand what it is about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
