tuhaihe commented on code in PR #1650: URL: https://github.com/apache/cloudberry/pull/1650#discussion_r3014750918
########## configure: ########## @@ -12235,7 +12236,9 @@ $as_echo "#define USE_MDBLOCALES 1" >>confdefs.h esac else - with_mdblocales=no + with_mdblocales=yes Review Comment: Based on the commit history, mdblocales has been enabled by default. The configure file in this PR was generated from the current configure.ac using autoconf, which reflects the existing default setting. I agree with your concern about disabling mdblocales by default. Since this PR is focused on regenerating the configure file from configure.ac, how about we create a separate PR to change the default behavior of mdblocales? That way we can discuss and review the default setting change independently. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
