harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r570860401
##########
File path: server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
##########
@@ -1325,18 +1325,18 @@ private long createNewVM(AutoScaleVmGroupVO asGroup) {
vm =
_userVmService.createBasicSecurityGroupVirtualMachine(zone, serviceOffering,
template, null, owner, "autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(),
"autoScaleVm-" + asGroup.getId() + "-" +
getCurrentTimeStampString(), null, null, null, HypervisorType.XenServer,
HTTPMethod.GET, null, null, null,
- null, true, null, null, null, null, null, null, null);
+ null, true, null, null, null, null, null, null, null,
true);
Review comment:
this parameter value in deploy VM flow is the one that read from deploy
VM API, where as in other cases there is no user/admin option to specify
whether the VM can be dynamically scalable or not, so it is defaulted to true.
All these method calls will reach checkIfDynamicScalingCanBeEnabled() where
other dynamic scaling flags from template, offering and global setting are
considered.
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3899,6 +3914,15 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
return vm;
}
+ private Boolean checkIfDynamicScalingCanBeEnabled(Boolean
dynamicScalingEnabled, ServiceOfferingVO offering, VMTemplateVO template, Long
zoneId) {
Review comment:
Just realised check at KubernetesClusterStartWorker class is redundant
one, I'll remove that and also try to use a common method in other classes.
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
