harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r571945677
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE :
isDynamicScalingEnabled;
Review comment:
fixed all Boolean to boolean, thanks for that.
Yes all old service offerings prior to upgrade will be marked as dynamically
scalable. This is made not to break existing VMs because service offering was
not part of dynamic scaling decision before. After upgrade we need to bypass
that check for old VMs, which can be achieved by marking them true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
