harikrishna-patnala opened a new pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643
### Description
This PR introduces new granularity levels to configure VM dynamic
scalability. Previously VM is configured to be dynamically scalable based on
the template and global setting. Now we bringing this option to configure at
service offering and VM level also.
VM can dynamically scale only when all flags are ON at VM level, template,
service offering and global setting. If any of the flags is set to false then
VM cannot be scalable. This result will be persisted in DB for each VM and will
be honoured for that VM till it is updated.
We are introducing 'dynamicscalingallowed' parameter with permitted values
of true or false for deployVM API and createServiceOffering API.
Following are the API parameter changes:
createServiceOffering API:
dynamicscalingenabled: an optional parameter of type Boolean with
default value “true”.
deployVirtualMachine API:
dynamicscalingenabled: an optional parameter of type Boolean with
default value “true”.
Following are the UI changes:
Service offering creation has ON/OFF switch for dynamic scaling enabled with
default value true.
Deploy VM wizard has ON/OFF switch for dynamic scaling enabled with default
value true in Advanced Mode section.
Added a documentation PR to support these changes
https://github.com/apache/cloudstack-documentation/pull/186
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*********************************************************************************
-->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*********************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
Following are the test cases that I've covered as part of my testing on
VMware environment.
**VM Creation:**
1. Created VM with Small service offering with all Flags ON
- VM1 (scalable)
2. Created VM with Small service offering which is not dynamic, with Dynamic
Scaling Enabled _true_ on VM
- VM2 (not scalable)
3. Created VM with Small service offering, with Dynamic Scaling Enabled
_false_ on VM
- VM3 (not scalable)
4. Created VM with Small service offering which is not dynamic, with Dynamic
Scaling Enabled _false_ on VM
- VM4 (not scalable)
5. Created VM with Small service offering with all dynamic flags ON except
template
- VM5 (not scalable)
**VM Update:**
1. Stop VM1 => set Dynamic Scaling Enabled to _false_ => Update VM
- VM is updated to Dynamic Scaling Enabled value _false_
2. Stop VM2 or VM3 or VM4 or VM5 => set Dynamic Scaling Enabled to _true_ =>
Update VM
- VM update operation fails because VM cannot be scaled with any
of the template/service offering/global setting dynamic scaling enabled flag
with _false_
**VM dynamic Scaling:**
While trying to scale VM from UI, it will only list service offering that
are suitable to scale and also offering with "Dynamic Scaling Enabled" value
same as old service offering.
1. Create Big Service Offering with Dynamic Scaling Enabled _true_
- SO1
2. Create Big Service Offering with Dynamic Scaling Enabled _false_
- SO2
3. Scale VM1 (scalable) to Service Offering SO1
- Successful
4. Scale VM1 (scalable) to Service Offering SO2
- Operation failed because, VM1 Service Offering is marked
Dynamic Scaling Enabled but not on SO2
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
