PaulAngus commented on pull request #4283: URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-859691225
I don’t know anything about another version of your idea, no one has pinged me to comment on it. I would be sad if the author of the other version hadn’t pinged you for your comments. Certainly nothing should be merged without tests. If there aren’t tests you should bring it up with whoever merged it and if you get no joy there, the community. Kind Regards Paul Angus From: Rodrigo D. Lopez ***@***.***> Sent: Friday, June 11, 2021 2:39 PM To: apache/cloudstack ***@***.***> Cc: Paul Angus ***@***.***>; Mention ***@***.***> Subject: Re: [apache/cloudstack] Removes unnecessary validations (#4283) @PaulAngus<https://github.com/PaulAngus> @shwstppr<https://github.com/shwstppr> This one is not needed anymore. Those that made trouble to merge this, has merged another branch that do exactly the same result. Many thanks to you all, prevents mine ideas to go through. but implements those ideas in another way and merge it without testes. you rock @weizhouapache<https://github.com/weizhouapache> @rafaelweingartner<https://github.com/rafaelweingartner> @GabrielBrascher<https://github.com/GabrielBrascher> thanks for the review — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/4283#issuecomment-859588534>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABEWL3DS5YIZWSNORY7PMFTTSIGV7ANCNFSM4QJS6M7Q>. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
