Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r695808853
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4179,6 +4179,7 @@ public UserVmVO doInTransaction(TransactionStatus status)
throws InsufficientCap
}
}
+ vm.setUserVmType(type);
Review comment:
cks nodes are at the end of the day UserVMs - hence, CKSNode userVM type
is to further categorize the user vm
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4603,12 +4604,54 @@ private UserVm startVirtualMachine(long vmId, Long
podId, Long clusterId, Long h
return vm;
}
+ private void addUserVMCmdlineArgs(Long vmId, VirtualMachineProfile
profile, DeployDestination dest, StringBuilder buf) {
+ UserVmVO k8sVM = _vmDao.findById(vmId);
+ buf.append(" template=domP");
+ buf.append(" name=").append(profile.getHostName());
+ buf.append(" type=").append(k8sVM.getUserVmType());
+ for (NicProfile nic : profile.getNics()) {
+ int deviceId = nic.getDeviceId();
+ if (nic.getIPv4Address() == null) {
+ buf.append("
eth").append(deviceId).append("ip=").append("0.0.0.0");
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
