Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r696281994
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##########
@@ -88,14 +89,7 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
libvirtComputingResource.applyDefaultNetworkRules(conn, vmSpec,
false);
// pass cmdline info to system vms
- if (vmSpec.getType() != VirtualMachine.Type.User) {
- String controlIp = null;
- for (final NicTO nic : vmSpec.getNics()) {
- if (nic.getType() == TrafficType.Control) {
- controlIp = nic.getIp();
- break;
- }
- }
+ if (vmSpec.getType() != VirtualMachine.Type.User ||
(vmSpec.getBootArgs() != null &&
vmSpec.getBootArgs().contains(UserVmManager.CKS_NODE))) {
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
// wait and try passCmdLine for 30 seconds at most for
CLOUDSTACK-2823
Review comment:
Currently, yes, we pass the cmdline args to CKS nodes as we do with
systemVMs - and this has been restricted to other userVMs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
