DaanHoogland commented on a change in pull request #5588:
URL: https://github.com/apache/cloudstack/pull/5588#discussion_r736577034



##########
File path: 
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java
##########
@@ -122,16 +133,16 @@ private Double findRatioValue(final String value) {
         return 1.0;
     }
 
-    private void updateHostMetrics(final Metrics metrics, final HostJoinVO 
host) {
-        metrics.incrTotalHosts();
-        metrics.addCpuAllocated(host.getCpuReservedCapacity() + 
host.getCpuUsedCapacity());
-        metrics.addMemoryAllocated(host.getMemReservedCapacity() + 
host.getMemUsedCapacity());
+    private void updateHostMetrics(final 
org.apache.cloudstack.metrics.MetricsServiceImpl.HostMetrics hostMetrics, final 
HostJoinVO host) {

Review comment:
       no @GutoVeronezi , thanks for pointing it out. It is an issue with my 
IDE, that has been haunting me since short. I'll fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to