DaanHoogland commented on a change in pull request #5588:
URL: https://github.com/apache/cloudstack/pull/5588#discussion_r736578289
##########
File path:
framework/cluster/src/main/java/com/cloud/cluster/ClusterManagerImpl.java
##########
@@ -1141,7 +1183,10 @@ private boolean pingManagementNode(final
ManagementServerHostVO mshost) {
return true;
} catch (final IOException e) {
if (e instanceof ConnectException) {
- s_logger.error("Unable to ping management server at " +
targetIp + ":" + mshost.getServicePort() + " due to ConnectException", e);
+ s_logger.error("Unable to ping management server at " +
targetIp + ":" + mshost.getServicePort() + " due to ConnectException");
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug("Unable to ping management server at "
+ targetIp + ":" + mshost.getServicePort() + " due to ConnectException", e);
Review comment:
@GutoVeronezi I prefer to keep stacktraces at `debug` level and just
clear messages at `error`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
