JoaoJandre opened a new pull request #6048: URL: https://github.com/apache/cloudstack/pull/6048
### Description This PR aims to refactor the Account class by changing both the account type and the account state to de facto enums to facilitate future ACS development. Moreover, the use of well-documented and clear enum classes is a good practice in Java, and as such, we should try to adopt such good practices to reduce our technical debt. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [X] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [X] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? This was tested in a local lab, since the refactoring affects a lot of classes, all the basic operations were tested: Creating new VMs; Creating new networks; Creating new volumes, snapshots and VM snapshots; Creating new accounts; Creating new roles; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
