ravening commented on a change in pull request #6048:
URL: https://github.com/apache/cloudstack/pull/6048#discussion_r819373321
##########
File path: api/src/main/java/org/apache/cloudstack/acl/RoleType.java
##########
@@ -20,20 +20,32 @@
import com.cloud.user.Account;
import com.google.common.base.Enums;
+import org.apache.log4j.Logger;
+
+import java.util.HashMap;
// Enum for default roles in CloudStack
public enum RoleType {
- Admin(1L, Account.ACCOUNT_TYPE_ADMIN, 1),
- ResourceAdmin(2L, Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN, 2),
- DomainAdmin(3L, Account.ACCOUNT_TYPE_DOMAIN_ADMIN, 4),
- User(4L, Account.ACCOUNT_TYPE_NORMAL, 8),
- Unknown(-1L, (short) -1, 0);
+ Admin(1L, Account.Type.ADMIN, 1),
+ ResourceAdmin(2L, Account.Type.RESOURCE_DOMAIN_ADMIN, 2),
+ DomainAdmin(3L, Account.Type.DOMAIN_ADMIN, 4),
+ User(4L, Account.Type.NORMAL, 8),
+ Unknown(-1L, null, 0);
Review comment:
Better to use `Type.UNKNOWN` rather than `null` to prevent unknown NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
