BryanMLima opened a new pull request, #6412: URL: https://github.com/apache/cloudstack/pull/6412
### Description The API `listApis` currently has too many redundant calls to the DB, which causes slowness on the ACS login. This PR aims to improve the time of login on ACS by refactoring the classes that implement the `APIChecker` interface. In my local lab, the login usually took 13 seconds, without login cache. With this new version, the login took around 2 seconds, with no login cache as well. Fixes: #5266 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? I created multiple accounts with the roles based on the following table. I compared this PR with a version with the unmodified `APIChecker`. And the number of APIs were returned as expected, as the table shows. | Role Type | 4.16.0.6 version | PR version | | ------ | ------ | ------ | | Root Admin | 624 | 624 | | Domain Admin | 180 | 180 | | Read-Only Admin | 312 | 312 | | Support Admin | 202| 202 | | User | 268 | 268 | Furthermore, I tried multiple functions through the UI with these accounts, and the APIs allowed were working correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
