joseflauzino commented on PR #6401: URL: https://github.com/apache/cloudstack/pull/6401#issuecomment-1208203849
@shwstppr > 1. While filtering stats, API is called with hidden fields. eg: First filter using start, end dates Then select All data. Check API call, it still contains start/enddate param even though they are hidden in UI. Good point. I fixed this bug now. > 2. Time in filter UI is shown in the local timezone and the same is used in the API call without any timezone. Does listVirtualMachinesUsageHistory API convert it to server time? I guess not and it won't list stats correctly in many cases The timestamps come in server timezone, but the `listVirtualMachinesUsageHistory` API does not do a conversion or anything like that. In fact, the API receives the date fields without timezone. But the reason for this goes beyond the API itself: Currently, the backend only supports dates in the `yyy-MM-dd` or `yyy-MM-dd HH:mm:ss` format, so there is no way to pass dates with timezone to the APIs (the related code is in the ParamProcessWorker class). I think it would be interesting to implement support for timezone date objects in the ACS APIs. However, this is beyond the scope of this PR, so my suggestion is to map this to another issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
