DaanHoogland commented on code in PR #6683:
URL: https://github.com/apache/cloudstack/pull/6683#discussion_r959253505
##########
server/src/main/java/com/cloud/api/ApiDBUtils.java:
##########
@@ -1806,11 +1806,12 @@ public static List<DomainRouterJoinVO>
newDomainRouterView(VirtualRouter vr) {
}
public static UserVmResponse newUserVmResponse(ResponseView view, String
objectName, UserVmJoinVO userVm, EnumSet<VMDetails> details, Account caller) {
- return s_userVmJoinDao.newUserVmResponse(view, objectName, userVm,
details, null, caller);
+ return s_userVmJoinDao.newUserVmResponse(view, objectName, userVm,
details, null, null, caller);
}
- public static UserVmResponse newUserVmResponse(ResponseView view, String
objectName, UserVmJoinVO userVm, EnumSet<VMDetails> details, Boolean
accumulateStats, Account caller) {
- return s_userVmJoinDao.newUserVmResponse(view, objectName, userVm,
details, accumulateStats, caller);
+ public static UserVmResponse newUserVmResponse(ResponseView view, String
objectName, UserVmJoinVO userVm, EnumSet<VMDetails> details, Boolean
accumulateStats,
Review Comment:
sonar is making a valid complaint about this use of `EnumSet<>` it is done
in all other methods around here but we should not add to that. Can you please
```suggestion
public static UserVmResponse newUserVmResponse(ResponseView view, String
objectName, UserVmJoinVO userVm, Set<VMDetails> details, Boolean
accumulateStats,
```
for your new method and all others? (obvioudsly this is a request not a
blocking remarks on your code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
