DaanHoogland commented on code in PR #6683:
URL: https://github.com/apache/cloudstack/pull/6683#discussion_r960330334
##########
server/src/main/java/com/cloud/api/query/ViewResponseHelper.java:
##########
@@ -135,14 +135,19 @@ public static List<InstanceGroupResponse>
createInstanceGroupResponse(InstanceGr
}
public static List<UserVmResponse> createUserVmResponse(ResponseView view,
String objectName, UserVmJoinVO... userVms) {
- return createUserVmResponse(view, objectName,
EnumSet.of(VMDetails.all), null, userVms);
+ return createUserVmResponse(view, objectName,
EnumSet.of(VMDetails.all), null, null, userVms);
}
public static List<UserVmResponse> createUserVmResponse(ResponseView view,
String objectName, EnumSet<VMDetails> details, UserVmJoinVO... userVms) {
- return createUserVmResponse(view, objectName, details, null, userVms);
+ return createUserVmResponse(view, objectName, details, null, null,
userVms);
}
public static List<UserVmResponse> createUserVmResponse(ResponseView view,
String objectName, EnumSet<VMDetails> details, Boolean accumulateStats,
UserVmJoinVO... userVms) {
+ return createUserVmResponse(view, objectName, details,
accumulateStats, null, userVms);
+ }
+
+ public static List<UserVmResponse> createUserVmResponse(ResponseView view,
String objectName, EnumSet<VMDetails> details, Boolean accumulateStats, Boolean
showUserData,
Review Comment:
```suggestion
public static List<UserVmResponse> createUserVmResponse(ResponseView
view, String objectName, Set<VMDetails> details, Boolean accumulateStats,
Boolean showUserData,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
