rohityadavcloud commented on code in PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#discussion_r1009092083
##########
server/src/main/java/com/cloud/hypervisor/KVMGuru.java:
##########
@@ -139,7 +185,7 @@ protected void configureVmOsDescription(VirtualMachine
virtualMachine, VirtualMa
guestOsMapping =
_guestOsHypervisorDao.findByOsIdAndHypervisor(guestOS.getId(),
getHypervisorType().toString(), hostVo.getHypervisorVersion());
}
- if (guestOsMapping == null || hostVo == null) {
+ if (guestOsMapping == null) {
Review Comment:
@fermosan
I read the code from main branch and it seems this can be null if hostId is
null in caller at line 126
https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/hypervisor/KVMGuru.java#L123
##########
server/src/main/java/com/cloud/hypervisor/KVMGuru.java:
##########
@@ -167,9 +213,9 @@ protected void
configureVmMemoryAndCpuCores(VirtualMachineTO virtualMachineTo, H
Long maxHostMemory = max.first();
Integer maxHostCpuCore = max.second();
- Long minMemory = virtualMachineTo.getMinRam();
+ long minMemory = virtualMachineTo.getMinRam();
Long maxMemory = minMemory;
- Integer minCpuCores = virtualMachineTo.getCpus();
+ int minCpuCores = virtualMachineTo.getCpus();
Review Comment:
@fermosan ?
##########
ui/public/config.json:
##########
@@ -63,5 +63,121 @@
"basicZoneEnabled": true,
"multipleServer": false,
"allowSettingTheme": true,
- "docHelpMappings": {}
+ "docHelpMappings": {
Review Comment:
Another note about package-lock.json - what version of npm do you have? (I
don't remember if we should be committing package-lock.json changes?)
##########
server/src/main/java/com/cloud/hypervisor/KVMGuru.java:
##########
@@ -167,9 +213,9 @@ protected void
configureVmMemoryAndCpuCores(VirtualMachineTO virtualMachineTo, H
Long maxHostMemory = max.first();
Integer maxHostCpuCore = max.second();
- Long minMemory = virtualMachineTo.getMinRam();
+ long minMemory = virtualMachineTo.getMinRam();
Review Comment:
@fermosan ?
##########
ui/public/config.json:
##########
@@ -63,5 +63,121 @@
"basicZoneEnabled": true,
"multipleServer": false,
"allowSettingTheme": true,
- "docHelpMappings": {}
+ "docHelpMappings": {
Review Comment:
@fermosan I could be wrong but I think these are generated/auto-generated
during build and need not be added to version history. cc @DaanHoogland
@shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
