soreana opened a new pull request, #6918:
URL: https://github.com/apache/cloudstack/pull/6918
### Description
As of now, it is possible to override the virtual router service offering
with global, domain, and account level configurations. What if a customer wants
to change the service offering for only one network? There isn't such an option
in Cloudstack. As an admin, you can only override the network offering for a
domain, account, or global, affecting all the networks in that domain, account,
or zone. This pull request aims to add a network-level setting to override the
virtual router service offering per network.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*********************************************************************************
-->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*********************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
To test this feature, please follow the below steps:
1. Create a network
2. Create VM in that network (to create a VR)
3. List the network and get the UUID of the network
4. Check the service offering of the network
5. Create a new router service offering
6. Set the `network.router.service.offering` to the UUID of the service
offering for the network using the cmk
7. Restart the network with clean up
8. Check the service offering of the network
Useful `cmk` commands:
```
(localcloud) 🐱 > list networks filter=id,name
{
"count": 2,
"network": [
{
"id": "c9d70872-b877-4f02-92b5-b4b08e1095d7",
"name": "isolated-network"
},
{
"id": "1ebf1ca9-7930-4f2f-8263-8da1840f02fc",
"name": "shared"
}
]
}
(localcloud) 🐱 > list configurations
networkid=c9d70872-b877-4f02-92b5-b4b08e1095d7
{
"configuration": [
{
"category": "Advanced",
"description": "Uuid of the service offering used by virtual routers
of this network; if NULL - account/system offering will be used",
"isdynamic": true,
"name": "network.router.service.offering",
"scope": "network",
"value": ""
}
],
"count": 1
}
(localcloud) 🐱 > list routers filter=serviceofferingid,serviceofferingname
{
"count": 1,
"router": [
{
"serviceofferingid": "f37ed5fd-6f26-4316-8b27-dbebb0b56a5a"
"serviceofferingname": "System Offering For Software Router"
}
]
}
(localcloud) 🐱 > update configuration
networkid=c9d70872-b877-4f02-92b5-b4b08e1095d7
name="network.router.service.offering"
value="5ad7f2c4-29e0-460b-901b-05ee8de8a0df"
{
"configuration": {
"category": "Advanced",
"description": "Uuid of the service offering used by virtual routers of
this network; if NULL - account/system offering will be used",
"isdynamic": true,
"name": "network.router.service.offering",
"scope": "network",
"value": "5ad7f2c4-29e0-460b-901b-05ee8de8a0df"
}
}
(localcloud) 🐱 > restart network id=c9d70872-b877-4f02-92b5-b4b08e1095d7
cleanup=true
{
"success": true
}
(localcloud) 🐱 > list routers filter=serviceofferingid,serviceofferingname
{
"count": 1,
"router": [
{
"serviceofferingid": "5ad7f2c4-29e0-460b-901b-05ee8de8a0df"
"serviceofferingname": "Medium Instance"
}
]
}
```
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
