JoaoJandre commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1053300957
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##########
@@ -34,7 +34,7 @@
public static final String CATEGORY_ALERT = "Alert";
public static enum Scope {
- Global, Zone, Cluster, StoragePool, Account, ManagementServer,
ImageStore, Domain
+ Global, Zone, Cluster, StoragePool, Account, Domain, ManagementServer,
ImageStore, Network
Review Comment:
> @JoaoJandre I didn't know that ACS uses the enums' order. It is surprising
for me cause the order might change over time. :) Anyway, I'm not aware of any
regression but I'm redoing the changes just to be safe.
Yeah, generally It is not the best idea to use the enums' order, but
unfortunately it is done in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
