rohityadavcloud commented on code in PR #6924:
URL: https://github.com/apache/cloudstack/pull/6924#discussion_r1098320084
##########
ui/src/permission.js:
##########
@@ -60,21 +60,29 @@ router.beforeEach((to, from, next) => {
next({ path: '/dashboard' })
NProgress.done()
} else if (to.path === '/verify2FA' || to.path === '/setup2FA') {
- if (store.getters.twoFaEnabled && !store.getters.loginFlag) {
+ const isSAML = JSON.parse(Cookies.get('isSAML') || Cookies.get('isSAML',
{ path: '/client' }) || false)
Review Comment:
@harikrishna-patnala suggestion: we shouldn't worry if this is 2FA enabled
or not; a general way to implement is to simply test if 2FA is required and
simply redirect to the appropriate path for the logged in user. (we assume once
SAML SSO has worked, the user has logged in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
